vagetablechicken commented on a change in pull request #2235: Support setting 
properties for storage_root_path
URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348917646
 
 

 ##########
 File path: be/src/olap/options.h
 ##########
 @@ -26,14 +26,25 @@
 namespace doris {
 
 struct StorePath {
-    StorePath() : capacity_bytes(-1) { }
-    StorePath(const std::string& path_, int64_t capacity_bytes_)
-        : path(path_), capacity_bytes(capacity_bytes_) { }
+    StorePath() : capacity_bytes(-1), storage_medium(TStorageMedium::HDD) { }
+    StorePath(const std::string &path_, int64_t capacity_bytes_)
 
 Review comment:
   ok, I chanced to see this, mistakely think that Doris align pointer to the 
right   
   
https://github.com/apache/incubator-doris/blob/42a4fff562090fc40bcab48684b4a61614f8d8f8/be/src/tools/meta_tool.cpp#L105
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to