imay commented on a change in pull request #1967: Lost rowset during tablet revise tablet meta URL: https://github.com/apache/incubator-doris/pull/1967#discussion_r334235694
########## File path: be/src/olap/tablet.h ########## @@ -242,6 +242,8 @@ class Tablet : public std::enable_shared_from_this<Tablet> { void build_tablet_report_info(TTabletInfo* tablet_info); + OLAPStatus clone_tablet_meta(TabletMetaSharedPtr new_tablet_meta); Review comment: In your implementation, there is no lock. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org