wangbo commented on a change in pull request #1944: Segment v2 use string's
real length(#1943)
URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334229094
##########
File path: be/src/olap/types.h
##########
@@ -601,22 +594,11 @@ struct FieldTypeTraits<OLAP_FIELD_TYPE_VARCHAR> : public
FieldTypeTraits<OLAP_FI
slice->size = value_len;
return OLAP_SUCCESS;
}
- static void set_to_max(void* buf) {
Review comment:
👌；We can unify char/varchar's set_to_max
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
