imay commented on a change in pull request #1944: Segment v2 use string's real
length(#1943)
URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334228888
##########
File path: be/src/olap/field.h
##########
@@ -55,9 +55,9 @@ class Field {
inline size_t field_size() const { return size() + 1; }
inline size_t index_size() const { return _index_size; }
- inline void set_to_max(char* buf) const { return
_type_info->set_to_max(buf); }
+ virtual inline void set_to_max(char* buf) const { return
_type_info->set_to_max(buf); }
inline void set_to_min(char* buf) const { return
_type_info->set_to_min(buf); }
- inline char* allocate_value_from_arena(Arena* arena) const { return
_type_info->allocate_value_from_arena(arena); }
+ virtual inline char* allocate_value_from_arena(Arena* arena) const {
return _type_info->allocate_value_from_arena(arena); }
Review comment:
we can get it through _type_info->size()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
