pan3793 commented on code in PR #272:
URL:
https://github.com/apache/datasketches-memory/pull/272#discussion_r2766677987
##########
datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/internal/ResourceImpl.java:
##########
@@ -151,9 +151,13 @@ public static void checkBounds(final long reqOff, final
long reqLen, final long
* @param p1 The second number group
*/
static void checkJavaVersion(final String jdkVer, final int p0, final int p1
) {
- final boolean ok = ((p0 == 1) && (p1 == 8)) || (p0 == 8) || (p0 == 11) ||
(p0 == 17 || (p0 == 21));
+ final boolean ok = ((p0 == 1) && (p1 == 8)) || (p0 == 8) || (p0 == 11) ||
(p0 == 17 || (p0 == 21) || (p0 == 25));
if (!ok) { throw new IllegalArgumentException(
- "Unsupported JDK Major Version. It must be one of 1.8, 8, 11, 17, 21:
" + jdkVer);
+ "Unsupported JDK Major Version. It must be one of 1.8, 8, 11, 17, 21,
25: " + jdkVer);
+ }
+ if (p0 > 11) {
+ System.err.println(
+ "Warning: Java versions > Java 11 can only operate in restricted
mode where no off-heap operations are allowed!");
Review Comment:
this makes sense, the only concern is, will it be too noisy? maybe add a
static field `JAVA_VERSION_WARNING_PRINTED` as a flag, then we can print it
just once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
