leerho commented on PR #271: URL: https://github.com/apache/datasketches-memory/pull/271#issuecomment-3849462933
I have been thinking about your request and looked at your code and found a few more things that needed to be fixed. So instead of this PR, I have submitted a different PR #272, that adds a warning so that users attempting to run this code with Java versions > 11 will get a warning that no off-heap operations can be used. As you can see, if you look at 272, I found a bunch of checkstyle warnings that needed to be fixed as well. Since 272 supersedes this one, I will close this one. Thank you for your suggestions on this. Please thoroughly test the new _prepare_3.0.3_ branch form 272 in your environment to make sure it works with 25 like you expect. Do not expect it to pass tests with Java versions > 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
