geonove commented on PR #98: URL: https://github.com/apache/datasketches-characterization/pull/98#issuecomment-3762084079
Change was to store the merge trial error into the pre-allocated `rank_errors` slot for the current trial instead of appending a new element. Previously `push_back` grew the inner vectors each trial and misaligned the rank/trial grid; now it writes to `rank_errors[j++][t]`, matching the intended rank-by-trial structure (since it the rank error vector is pre-allocated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
