devillove084 opened a new issue, #464: URL: https://github.com/apache/datasketches-cpp/issues/464
Description When compiling code that includes and uses the hll_sketch class with the Clang compiler, a -Wunnecessary-virtual-specifier warning is generated. The warning points to the destructor of the hll_sketch_alloc class, which is marked as virtual while the class itself is declared as final. ``` text Virtual method '~hll_sketch_alloc' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
