This is an automated email from the ASF dual-hosted git repository. leerho pushed a commit to branch cleanup_phase3 in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit b193b7012ca0460548502c576c9f5da4b6d6a242 Author: Lee Rhodes <[email protected]> AuthorDate: Sun Aug 24 14:49:22 2025 -0700 Set pom to min java version of 22. Set minimum Maven version to 3.9.11. Remove obsolete ds-memory reference. --- pom.xml | 5 ++--- src/main/java/org/apache/datasketches/hll/HllSketch.java | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 972d21449..75247f638 100644 --- a/pom.xml +++ b/pom.xml @@ -83,7 +83,6 @@ under the License. </developers> <properties> - <datasketches-memory.version>6.1.0-SNAPSHOT</datasketches-memory.version> <!-- Test --> <testng.version>7.11.0</testng.version> @@ -94,7 +93,7 @@ under the License. <testng.check-cpp-historical-files>check_cpp_historical_files</testng.check-cpp-historical-files> <!-- System-wide properties --> - <maven.version>3.9.10</maven.version> + <maven.version>3.9.11</maven.version> <java.version>24</java.version> <jvm-arguments>-Xmx4g -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8</jvm-arguments> <maven.compiler.source>${java.version}</maven.compiler.source> @@ -184,7 +183,7 @@ under the License. <configuration> <rules> <requireJavaVersion> - <version>[24,)</version> <!-- java.version --> + <version>[22,)</version> </requireJavaVersion> <requireMavenVersion> <version>[${maven.version},4.0.0)</version> diff --git a/src/main/java/org/apache/datasketches/hll/HllSketch.java b/src/main/java/org/apache/datasketches/hll/HllSketch.java index 9709ad69d..35d782a27 100644 --- a/src/main/java/org/apache/datasketches/hll/HllSketch.java +++ b/src/main/java/org/apache/datasketches/hll/HllSketch.java @@ -238,7 +238,7 @@ public class HllSketch extends BaseHllSketch { * <p>The given <i>dstSeg</i> is checked for the required capacity as determined by * {@link #getMaxUpdatableSerializationBytes(int, TgtHllType)}. * @param srcWseg an writable image of a valid source sketch with data. - * @return an HllSketch where the sketch data is in the given dstSeg. + * @return an HllSketch where the sketch data is in the given srcWseg. */ public static final HllSketch writableWrap(final MemorySegment srcWseg) { if (srcWseg.isReadOnly()) { return wrap(srcWseg); } @@ -251,7 +251,7 @@ public class HllSketch extends BaseHllSketch { checkBounds(0, 8, srcWseg.byteSize()); //need min 8 bytes if (extractCompactFlag(srcWseg)) { throw new SketchesArgumentException( - "Cannot perform a writableWrap of a writable sketch image that is in compact form. " + "Cannot perform a writableWrap of a sketch image that is in compact form. " + "Compact sketches are by definition immutable."); } final int lgConfigK = extractLgK(srcWseg); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
