freakyzoidberg commented on PR #670:
URL:
https://github.com/apache/datasketches-java/pull/670#issuecomment-3058815211
Aside from the stray debug LGTM.
As discussed on Slack - their may be some win to get performance or safety
wise following those practice
but could definitely be evaluated later
Thanks !
``` Resource Management
// Recommended pattern for Arena usage
try (Arena arena = Arena.ofConfined()) {
MemorySegment segment = arena.allocate(size);
// Use segment
} // Automatic cleanup
Error Handling Standardization
// Standardized validation pattern
private static void validateSegmentBounds(MemorySegment seg, long offset,
long length) {
if (offset < 0 || length < 0 || offset + length > seg.byteSize()) {
throw new SketchesArgumentException("Segment access out of
bounds");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
