Copilot commented on code in PR #669:
URL: https://github.com/apache/datasketches-java/pull/669#discussion_r2187735762
##########
src/test/java/org/apache/datasketches/theta/UnionImplTest.java:
##########
@@ -222,8 +223,8 @@ public void checkMoveAndResizeOffHeap() {
final MemorySegment uWsegHeap = MemorySegment.ofArray(new byte[bytes /
2]);
final Union union2 = SetOperation.builder().buildUnion(); //on-heap union
- assertFalse(isSameResource(uWseg, uWsegHeap)); //obviously not
- assertFalse(isSameResource(uWsegHeap, union.getMemorySegment())); //tgt
moved
+ assertFalse(MemorySegmentStatus.isSameResource(uWseg, uWsegHeap));
//obviously not
+ assertFalse(MemorySegmentStatus.isSameResource(uWsegHeap,
union.getMemorySegment())); //tgt moved
Review Comment:
The test constructs the on-heap union in `union2` but then checks
`union.getMemorySegment()`. It should reference `union2.getMemorySegment()` to
validate the correct instance.
```suggestion
assertFalse(MemorySegmentStatus.isSameResource(uWsegHeap,
union2.getMemorySegment())); //tgt moved
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
