AlexanderSaydakov commented on PR #458: URL: https://github.com/apache/datasketches-cpp/pull/458#issuecomment-2956464394
> Serialized bytes cannot be used to rebuild the tdigest in java Well, why not? The format is known, so the bytes can be interpreted correctly. I am not saying this is the best way, just wanted to point out that the statement is not quite correct. I don't mind const iterator over centroids, but that feels a bit awkward to me. As if we are exposing implementation details. We have an internal method deserialize_compat() to read the reference implementation format. We did not expose it since deserialize can detect and delegate. Perhaps a better approach would be to have a serialize_compat() or something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
