geonove opened a new pull request, #455:
URL: https://github.com/apache/datasketches-cpp/pull/455
I noticed that this test
```cpp
TEST_CASE("CM parameter suggestions", "[error parameters]") {
// Bucket suggestions
REQUIRE_THROWS(count_min_sketch<uint64_t>::suggest_num_buckets(-1.0),
"Confidence must be between 0 and 1.0 (inclusive)." );
//...
```
was still passing even though `suggest_num_buckets` throws the following
error message: `"Relative error must be at least 0."`.
This is because `REQUIRE_THROWS` doesn't check if the error message match.
`REQUIRE_THROWS_WITH` should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
