jmalkin commented on code in PR #258: URL: https://github.com/apache/datasketches-memory/pull/258#discussion_r1940295637
########## src/test/java/org/apache/datasketches/memory/internal/NativeWritableMemoryImplTest.java: ########## @@ -19,7 +19,14 @@ package org.apache.datasketches.memory.internal; -import static org.apache.datasketches.memory.internal.ResourceImpl.NON_NATIVE_BYTE_ORDER; +import static org.apache.datasketches.memory.internal.UtilForTest.CB; +import static org.apache.datasketches.memory.internal.UtilForTest.DB; +import static org.apache.datasketches.memory.internal.UtilForTest.FB; +import static org.apache.datasketches.memory.internal.UtilForTest.IB; +import static org.apache.datasketches.memory.internal.UtilForTest.LB; +import static org.apache.datasketches.memory.internal.UtilForTest.NBO; +import static org.apache.datasketches.memory.internal.UtilForTest.NNBO; +import static org.apache.datasketches.memory.internal.UtilForTest.SB; Review Comment: These imports make the code much harder to read. They are not self-explanatory from reading the name. This was not an actively bad change, IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
