This is an automated email from the ASF dual-hosted git repository. leerho pushed a commit to branch update_tools_in_main in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 16a00a97c6309b6574889d1b255cbbb8a3bca399 Author: Lee Rhodes <[email protected]> AuthorDate: Fri Jan 3 16:53:46 2025 -0800 Remove two obsolete files. Update Sketches Checkstyle.xml --- tools/CloverConfig.txt | 50 -------------------------------------------- tools/SketchesCheckstyle.xml | 15 ++++++------- tools/suppressions.xml | 29 ------------------------- 3 files changed, 6 insertions(+), 88 deletions(-) diff --git a/tools/CloverConfig.txt b/tools/CloverConfig.txt deleted file mode 100644 index 845fede8..00000000 --- a/tools/CloverConfig.txt +++ /dev/null @@ -1,50 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -Clover Config for Eclipse: - -At Project Level Properties: -Clover: - Instrumentation: - Initstring: Default value - Output Folder: ...project output dir(s) - Flush Policy: At JVM shutdown ... - Misc: Fully qualify ... , Instrument and compile at statement level - Contexts: - Check: assert statements - Add Custom Coverage Context Filter: - private-constructor: also see link below - Method - (.* )?private +[a-zA-Z0-9_$]+ *\( *\).* - Source Files - Only look ... - [check] src/main/java[includes=**/*.java][excludes=] - [check] src/test/java[includes=**/*.java][excludes=] - Test Classes - Assume all source in the specified folders are tests or test utility classes - [check] src/test/java - -At Clover "down-triangle" menu: - Columns: - Element - % TOTAL Coverage - Uncovered Elements: Custom: %UncoveredElements * TotalElements / 100 - Total Elements - - - -http://alexruizlog.blogspot.com/2009/04/how-to-make-clover-ignore-private_21.html \ No newline at end of file diff --git a/tools/SketchesCheckstyle.xml b/tools/SketchesCheckstyle.xml index 184a05ad..53726a2c 100644 --- a/tools/SketchesCheckstyle.xml +++ b/tools/SketchesCheckstyle.xml @@ -49,10 +49,12 @@ under the License. <property name="fileNamePattern" value=".*[\\/]src[\\/]test[\\/].*$"/> </module> + <!-- flag the first instance of a tab character in each java, xml, yml or yaml file --> <module name="FileTabCharacter"> - <property name="eachLine" value="true"/> + <property name="fileExtensions" value="java, xml, yml, yaml"/> </module> + <!-- each package must have a package-info.java file --> <module name="JavadocPackage"/> <module name="NewlineAtEndOfFile"> @@ -67,6 +69,7 @@ under the License. <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> --> </module> + <!-- Filters --> <module name="SuppressWithPlainTextCommentFilter"> <property name="offCommentFormat" value="//CHECKSTYLE.OFF\: ([\w\|]+)"/> <property name="onCommentFormat" value="//CHECKSTYLE.ON\: ([\w\|]+)"/> @@ -80,13 +83,6 @@ under the License. <!-- Be able to ignore violations with @SuppressWarnings --> <!-- See https://checkstyle.org/filters/suppresswarningsfilter.html --> <module name="SuppressWarningsHolder"/> - - <!-- - <module name="SuppressionFilter"> - <property name="file" value="basedir/tools/suppressions.xml"/> - <property name="optional" value="false"/> - </module> - --> <!-- Annotations --> <module name="AnnotationLocation"> @@ -230,7 +226,8 @@ under the License. <property name="allowedAnnotations" value="Override, Test"/> </module> - <!-- <module name="JavadocParagraph"/> disabled because of a Checkstyle bug with <p> after @param --> + <!-- disabled because of a Checkstyle bug with <p> after @param --> + <!-- <module name="JavadocParagraph"/> --> <module name="JavadocTagContinuationIndentation"> <property name="severity" value="ignore"/> diff --git a/tools/suppressions.xml b/tools/suppressions.xml deleted file mode 100644 index 91b8833c..00000000 --- a/tools/suppressions.xml +++ /dev/null @@ -1,29 +0,0 @@ -<?xml version="1.0"?> - -<!DOCTYPE suppressions PUBLIC - "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN" - "https://checkstyle.org/dtds/suppressions_1_2.dtd";> - - <!-- - Licensed to the Apache Software Foundation (ASF) under one - or more contributor license agreements. See the NOTICE file - distributed with this work for additional information - regarding copyright ownership. The ASF licenses this file - to you under the Apache License, Version 2.0 (the - "License"); you may not use this file except in compliance - with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - - Unless required by applicable law or agreed to in writing, - software distributed under the License is distributed on an - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - KIND, either express or implied. See the License for the - specific language governing permissions and limitations - under the License. - --> - -<suppressions> - <suppress checks="Javadoc" files=".*[\\/]src[\\/](test|it)[\\/]"/> - <suppress checks="MagicNumber" files=".*[\\/]src[\\/](test|it)[\\/]"/> -</suppressions> \ No newline at end of file --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
