frankgrimes97 commented on PR #241: URL: https://github.com/apache/datasketches-memory/pull/241#issuecomment-2484119877
> * The GitHub/Actions/Workflows will need to be updated to Java 21. Otherwise, guaranteed to fail. I can look at adding another commit on this PR to address the GitHub Actions/Workflows changes required once I familiarize myself with them. > -- I presume this only applies to all NetBeans users only?? Yes, that's the case... I see now that I should have simply added it to the `.gitignore` file for consistency for how these kinds of files are currently handled for Eclipse and IntelliJ: ``` # Eclipse project files .classpath .project .settings/ .checkstyle # IntelliJ project files *.idea *.iml *.ipr *.iws # Netbeans project files nb-configurations.xml ``` I can amend the PR to do so. FYI, I also added `nb-configurations.xml` to the `apache-rat-plugin`'s exclusions in the `pom.xml` to avoid it complaining with: ``` Too many files with unapproved license ``` I can remove that as well since when building locally I could just skip the spurious license check failure with the right local `mvn` build arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
