jmalkin commented on code in PR #182: URL: https://github.com/apache/datasketches-memory/pull/182#discussion_r1597543101
########## .github/workflows/auto-jdk-matrix.yml: ########## @@ -0,0 +1,67 @@ +name: DataSketches-Memory Auto JDK Matrix Test & Install + +on: + pull_request: + push: + # branches: [ master ] + workflow_dispatch: + +env: + MAVEN_OPTS: -Xmx4g -Xms1g Review Comment: Do we actually need 4g?? ########## .github/workflows/auto-jdk-matrix.yml: ########## @@ -0,0 +1,67 @@ +name: DataSketches-Memory Auto JDK Matrix Test & Install + +on: + pull_request: + push: + # branches: [ master ] Review Comment: Dunno if you wanted this commented out? Certainly not a blocker to the PR either way, but ideally either uncomment or remove the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
