This is an automated email from the ASF dual-hosted git repository.
erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git
The following commit(s) were added to refs/heads/master by this push:
new 7dd7f504 chore: cleanup PermissionHelper (#1925)
7dd7f504 is described below
commit 7dd7f5042c47f8bf37598a32400c596df79d536e
Author: Manuel Beck <[email protected]>
AuthorDate: Tue Jun 30 08:58:16 2026 +0200
chore: cleanup PermissionHelper (#1925)
* chore: cleanup PermissionHelper
- AndroidStudio complained about methods not found linked in JavaDoc for
the class CordovaInterface: requestPermission(), requestPermissions() and
hasPermission(). The parameter types were missing and were added.
- Removing unused imports
* fix: Add missing `@Deprecated` Java annotations
---
framework/src/org/apache/cordova/PermissionHelper.java | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/framework/src/org/apache/cordova/PermissionHelper.java
b/framework/src/org/apache/cordova/PermissionHelper.java
index 90c6e169..924924ae 100644
--- a/framework/src/org/apache/cordova/PermissionHelper.java
+++ b/framework/src/org/apache/cordova/PermissionHelper.java
@@ -18,12 +18,6 @@
*/
package org.apache.cordova;
-import java.util.Arrays;
-
-import org.json.JSONException;
-
-import android.content.pm.PackageManager;
-
/**
* This class is permission helper class when compiling against older versions
of cordova-android pre 5.0.0
* and provides reflective methods for permission requesting and checking so
that plugins
@@ -38,6 +32,7 @@ import android.content.pm.PackageManager;
* @deprecated As of cordova-android 5.0.0, this class is no longer needed and
will be removed in a future release.
* You can call directly into {@link CordovaInterface} methods instead with
{@link CordovaPlugin#cordova}.
*/
+@Deprecated
public class PermissionHelper {
/**
* Requests a "dangerous" permission for the application at runtime. This
is a helper method
@@ -48,8 +43,9 @@ public class PermissionHelper {
* @param requestCode A requestCode to be passed to the plugin's
onRequestPermissionResult()
* along with the result of the permission request
* @param permission The permission to be requested
- * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#requestPermission()} instead.
+ * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#requestPermission(CordovaPlugin, int, String)} instead.
*/
+ @Deprecated
public static void requestPermission(CordovaPlugin plugin, int
requestCode, String permission) {
PermissionHelper.requestPermissions(plugin, requestCode, new String[]
{permission});
}
@@ -63,8 +59,9 @@ public class PermissionHelper {
* @param requestCode A requestCode to be passed to the plugin's
onRequestPermissionResult()
* along with the result of the permissions request
* @param permissions The permissions to be requested
- * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#requestPermissions()} instead.
+ * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#requestPermissions(CordovaPlugin, int, String[])} instead.
*/
+ @Deprecated
public static void requestPermissions(CordovaPlugin plugin, int
requestCode, String[] permissions) {
plugin.cordova.requestPermissions(plugin, requestCode, permissions);
}
@@ -77,8 +74,9 @@ public class PermissionHelper {
* @param plugin The plugin the permission is being checked against
* @param permission The permission to be checked
* @return True if the permission has already been granted
and false otherwise
- * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#hasPermission()} instead.
+ * @deprecated As of cordova-android 5.0.0, use {@link
CordovaInterface#hasPermission(String)} instead.
*/
+ @Deprecated
public static boolean hasPermission(CordovaPlugin plugin, String
permission) {
return plugin.cordova.hasPermission(permission);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
