(commons-compress) branch master updated: Pack200 class IcBands.IcTuple implements equals() but not hashCode().

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new ba49a92a0 Pack200 class IcBands.IcTuple implements equals() but not 
hashCode().
ba49a92a0 is described below

commit ba49a92a08e08a9d2314c793efe1a79974c4f147
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Mar 5 22:54:33 2026 -0500

    Pack200 class IcBands.IcTuple implements equals() but not hashCode().
---
 src/changes/changes.xml                                             | 1 +
 .../java/org/apache/commons/compress/harmony/pack200/IcBands.java   | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 90f699758..1394d09ac 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -135,6 +135,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix all Javadoc 
warnings.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory, Shan Jiang" 
issue="COMPRESS-719">CPConstant subclasses are missing optional hashCode() and 
equals() to match its Comparable.compareTo().</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">CPUTF8 is 
missing optional hashCode() and equals() to match its 
Comparable.compareTo().</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Pack200 class 
IcBands.IcTuple implements equals() but not hashCode().</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
MemoryLimitException.MemoryLimitException(long, long).</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
CompressException.CompressException(String, Object...).</action>
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java 
b/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
index 55562bfd4..220a9216b 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/IcBands.java
@@ -29,7 +29,7 @@
 import java.util.TreeSet;
 
 /**
- * Inner class bands (corresponds to the {@code ic_bands} set of bands in the 
pack200 specification)
+ * Inner class bands. Corresponds to the {@code ic_bands} set of bands in the 
pack200 specification.
  *
  * @see <a 
href="https://docs.oracle.com/en/java/javase/13/docs/specs/pack-spec.html";>Pack200:
 A Packed Class Deployment Format For Java Applications</a>
  */
@@ -63,6 +63,10 @@ public boolean equals(final Object o) {
             return false;
         }
 
+        public int hashCode() {
+            return Objects.hash(C, F, C2, N);
+        }
+
         public boolean isAnonymous() {
             final String className = C.toString();
             final String innerName = 
className.substring(className.lastIndexOf('$') + 1);