ngrosc opened a new issue #4519:
URL: https://github.com/apache/cloudstack/issues/4519
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete
the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
UI: SAML login
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master
branch.
-->
~~~
4.14.0.0
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network,
advanced networking, etc. N/A otherwise
-->
SAML authentication activated
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
The SAML signature is optional and not mandatory. A user can login into a
domain where he's not allowed to.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal
test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
Use a tool to intercept the web requests between your browser ant the
cloudstack UI (our pentester used "burp"). Login to cloudstack using a SSO
account (SAML).
Now, you're logged in successfully to your cloudstack domain.
Logout from cloudstack.
Now, log in again to cloudstack, but with the "interceptor" active. In the
request, delete the whole saml-signature and change the username to another SSO
user from within another tenant.
Run the modified request, and you're logged in into this foreign account.
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
User can't log in into foreign tenant
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
User can log in into foreign tenant
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
