andrijapanicsb commented on a change in pull request #4250:
URL: https://github.com/apache/cloudstack/pull/4250#discussion_r474564204



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql
##########
@@ -309,3 +309,86 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
hypervisor_type, hype
 
 -- Copy XenServer 8.0 hypervisor guest OS mappings to XenServer8.1
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
SELECT UUID(),'Xenserver', '8.1.0', guest_os_name, guest_os_id, 
utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE 
hypervisor_type='Xenserver' AND hypervisor_version='8.0.0';
+
+-- Add mincpu, maxcpu, minmemory and maxmemory to the view supporting 
constrained offerings
+ALTER VIEW `cloud`.`service_offering_view` AS

Review comment:
       @nvazquez afaik, we've discussed that we always want to drop/replace 
view, not alter it, due to whatever issues someone noticed in some cases




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to