rhtyd commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r448787251
########## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ########## @@ -472,11 +473,16 @@ public static final String PROJECT = "project"; public static final String ROLE = "role"; public static final String ROLE_ID = "roleid"; + public static final String ACCOUNT_ROLE_TYPE = "accountroletype"; + public static final String PROJECT_ROLE_ID = "projectroleid"; + public static final String PROJECT_ROLE_NAME = "projectrolename"; + public static final String PROJECT_ROLE_TYPE = "projectroletype"; public static final String ROLE_TYPE = "roletype"; public static final String ROLE_NAME = "rolename"; public static final String PERMISSION = "permission"; public static final String RULE = "rule"; public static final String RULE_ID = "ruleid"; + public static final String PROJECT_RULE_ID = "projectruleid"; Review comment: nit - probably this means projectrolepermissionid? (yes, naming is hard, I'm trying to guess what is parameter is for) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org