DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM
ingestion
URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343818702
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -799,16 +822,14 @@ private Answer execute(ResizeVolumeCommand cmd) {
_storageProcessor.expandDatastore(hostDatastoreSystem, dsMo);
}
- if (vdisk.second() != null &&
!vdisk.second().toLowerCase().startsWith("scsi"))
- {
- s_logger.error("Unsupported disk device bus "+ vdisk.second());
- throw new Exception("Unsupported disk device bus "+
vdisk.second());
+ if (vdisk.second() != null &&
!vdisk.second().toLowerCase().startsWith("scsi")) {
Review comment:
```
indian hill {
puts the opening bracket/accolade at the end of the line
{
as oposed to below the condition or loop statement it belongs to
}
} and closes below as the symetric block do
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
