andrijapanicsb edited a comment on issue #3609: Improve Guest OS additions and mappings URL: https://github.com/apache/cloudstack/issues/3609#issuecomment-536526277 I believe we effectively need to handle 2 tables: guest_os and guest_os_hypervisor (expecting that end-users will NOT have a need to change guest_os_category or guest_os_details) Current code behaviour (tested with 4.11/4.13): - from the **guest_os table**, show all duplicates (if any, should be none usually) - this is what's visible in the listOsTypes or in the GUI (and it does show duplicates when testing) - from the **guest_os_hypervisor table**, show the latest (last row) matching hypervisor os mappings if there are any duplicates (i.e. there is at least one duplicate example for Windows Server 2016 for VMware 6.5 and later, which you can observe with: `SELECT * FROM guest_os_hypervisor WHERE hypervisor_type="VMware" and hypervisor_version="6.5" and guest_os_id IN (SELECT id FROM guest_os WHERE display_name="Windows Server 2016 (64-bit)");` **Possible improvements as following:** **guest_os table** - when inserting new guest OSes, simply SKIP defining the ID, and this will use the next ID available - make sure to "read" the "id" assigned to that record, since we'll probably need it to add new referencing records in the guest_os_hypervisor table later **guest_os_hypervisor table** - skip defining the ID explicitly while adding new mappings, let auto-increment work its stuff - keep the current behaviour of using the last (with highest ID) records from this table (if there are duplicates), which allows us to "override" identical mapping that the end-users might have created previously (before the upgrade) - make sure to reference the correct ID from the **guest_os** table that was auto-incremented - this seems to be the only "complexity" here This would allow for: - end-users to add their own OS and OS mappings with whatever IDs they might use - during schema upgrades, allow us to "override" this by adding identical records as the part of the upgrade path with higher IDs, which will be the only one "honored", thus obsoleting the previously added user-records FTR:  -
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
