[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

[GitBox]

ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks 
and VIRTIO for data disks when platform emulator strings start with Windows* 
except Windows PV
URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509371457
 
 
   Agree with you.
   Furthermore, I think it is better to use 
   ```
   platformEmulator.contains("Ubuntu")
   ```
   because some users use "Other Ubuntu" for the Ubuntu versions which are not 
in the list, for example Ubuntu 17.04, Ubuntu 18.04.
   
   
   > Regardless of this fix ... the code below should included in any case 
because it looks ugly at the moment. (code below)
   > 
   > ```java
   >         } else if (platformEmulator.startsWith("Ubuntu") ||
   >                 platformEmulator.startsWith("Fedora") ||
   >                 platformEmulator.startsWith("CentOS") ||
   >                 platformEmulator.startsWith("Red Hat Enterprise Linux") ||
   >                 platformEmulator.startsWith("Debian GNU/Linux") ||
   >                 platformEmulator.startsWith("FreeBSD") ||
   >                 platformEmulator.startsWith("Oracle") ||
   >                 platformEmulator.startsWith("Windows PV") ||
   >                 platformEmulator.startsWith("Other PV")) {
   > ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services