[GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

[GitBox]

svenvogel edited a comment on issue #3319: Use IDE as the bus type for root 
disks and VIRTIO for data disks when platform emulator strings start with 
Windows* except Windows PV
URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310
 
 
   wow many answers. okay lets bring some light into the issue.
   
   first of all i think all here understand the problem. 
   https://github.com/apache/cloudstack/pull/3319#issuecomment-491415223
   
   if this so then lets talk about test and if we found the right place for the 
code.
   
   We use Netapp Solidfire managed storage and KVM.
   
   @kiwiflyer thats for our customer and devs they dont want to install virtio 
driver in the image before or with boot time ;). so ide is "slower" than virto 
but its easier for them. we only want the normal configuration like the other 
systems. if we want complete virtio we can choose it.
   
   @ustcweizhou yes. so what we found out is that it was only with windows os 
and yes we use KVM. 
   KVM (libvirt/qemu) wants only one ide disk root disk and the other one 
should be virtio. 
   
   ping We should ask @syed and @skattoju4 for that. maybe you are right. what 
do you think to what @ustcweizhou says?
   
   ---
   regardless of this fix ... the code below should included in any case 
because it looks ugly at the moment. (code below)
   
   ```java
           } else if (platformEmulator.startsWith("Ubuntu") ||
                   platformEmulator.startsWith("Fedora") ||
                   platformEmulator.startsWith("CentOS") ||
                   platformEmulator.startsWith("Red Hat Enterprise Linux") ||
                   platformEmulator.startsWith("Debian GNU/Linux") ||
                   platformEmulator.startsWith("FreeBSD") ||
                   platformEmulator.startsWith("Oracle") ||
                   platformEmulator.startsWith("Windows PV") ||
                   platformEmulator.startsWith("Other PV")) {
   
   please lets find the correct code place together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services