rhtyd commented on a change in pull request #3390: Add more info for creating
volume snapshots
URL: https://github.com/apache/cloudstack/pull/3390#discussion_r291953397
##########
File path: ui/scripts/storage.js
##########
@@ -944,7 +944,14 @@
var jid =
json.createsnapshotresponse.jobid;
args.response.success({
_custom: {
- jobId: jid //take snapshot
from a volume doesn't change any property in this volume. So, don't need to
specify getUpdatedItem() to return updated volume. Besides, createSnapshot API
doesn't return updated volume.
+ jobId: jid, //take
snapshot from a volume doesn't change any property in this volume. So, don't
need to specify getUpdatedItem() to return updated volume. Besides,
createSnapshot API doesn't return updated volume.
+ onComplete: function(json,
customData) {
+ var volumeId =
json.queryasyncjobresultresponse.jobresult.snapshot.volumeid;
+ var snapshotId =
json.queryasyncjobresultresponse.jobresult.snapshot.id;
+
cloudStack.dialog.notice({
+ message: "Created
snapshot for volume " + volumeId + " with snapshot id " + snapshotId
Review comment:
nit - `id` should be written as `ID` wherever possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
