DaanHoogland commented on a change in pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#discussion_r291064067
########## File path: test/integration/component/test_tags.py ########## @@ -1756,6 +1756,7 @@ def test_15_project_tag(self): listall=True, resourceType='project', resourceIds=project.id, + projectid=project.id, Review comment: on second thought @rhtyd , it won't work. There is no resource ID unless the project ID is passed as such. in the call there is no information that we can use ``` listall=True, resourceType='project', key=tag_key, ``` We could get the current account from the call context but that would only satisfy some use-cases. if an admin wants tags for some project they are not in we still need the parameter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services