webermaximilian92 opened a new pull request #3307: Feature add scss to css 
compiler
URL: https://github.com/apache/cloudstack/pull/3307
 
 
   ## Description
   _Copy of https://github.com/apache/cloudstack/pull/3301 because I run into 
troubles after changing my username_
   
   <!--- Describe your changes in detail -->
   This adds an gulp tasks, to build existing css files out of scss files and 
enables advantages for working with style rules. 
   Also this will reduce the complexibility of heavy css files **in all future 
css changes**.
   
   
   -     Using CSS is no longer the common standard for complex pages like 
cloudstack
   -     SASS (https://sass-lang.com/) or SCSS are preprocessors of CSS. 
Similar to ES6 or TypeScript for JavaScript.
   -     SCSS files are compiled to CSS files ones while development or 
deployment, and not on every page request
   -     SCSS provides us many logical functions and advantages to organise CSS 
rules more easily and less redundand with features like variables and so called 
mixins
   -     SCSS let us work more modular and is better maintainable
   -     We could split CSS files too, but this is not best practice, since 
many CSS files will result in many server requests and with SCSS it's possible 
to compile many files into one single CSS file (full automatically in just 
under a second after any SCSS changes)
   -     This compiled CSS file could also get minified, which will enhance 
loading times of cloudstack pages.
   
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   (This changes modify and unify the structure of css code only.)
   All we have to check yet, is if .css file-changes include only: indentation, 
spaces and quotes.
   
   It's very useful to reduce the diff to non whitespace changes here:
   ![Screenshot 2019-04-26 at 16 23 
44](https://user-images.githubusercontent.com/46194969/56814734-14f05080-6840-11e9-9924-23559ae6dd1f.png)
   
   
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   
   
   
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to