wido commented on a change in pull request #3186: Add possibility to set KVM
MTU size for NIC
URL: https://github.com/apache/cloudstack/pull/3186#discussion_r265576614
##########
File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java
##########
@@ -487,6 +490,10 @@ public static boolean validIpRange(final String startIP,
final String endIP) {
return startIPLong <= endIPLong;
}
+ public static boolean isValidMtu(final int mtu) {
Review comment:
Shouldn't we check for null here as well? If null, return false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
