[GitHub] [cloudstack] dhlaluku opened a new pull request #3222: volume: fix volume metrics view from returning sensitive info to end user

[GitBox]

dhlaluku opened a new pull request #3222: volume: fix volume metrics view from 
returning sensitive info to end user
URL: https://github.com/apache/cloudstack/pull/3222
 
 
   ## Description
   <!--- Describe your changes in detail -->
   The listVolumeMetrics API response does not honor the volume detail 
visibility restrictions set for normal users and returns sensitive information 
which should only be visible to the root admin. This PR fixes these and 
introduces the following behavior;
   
       * Hide physical size, storage type and storage pool details for 
non-admins
       * Show disk utilization metrics for all user types
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   User metrics view from the UI with  physical size, storage type, and storage 
pool details hideen
   
![image](https://user-images.githubusercontent.com/19572501/54263956-b1a1ac00-457a-11e9-96c2-c1d7e03f0797.png)
   
   Admin Response contains the full display view/results
   
![image](https://user-images.githubusercontent.com/19572501/54264032-dd249680-457a-11e9-9982-6d589e492f5a.png)
   
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services