kioie commented on a change in pull request #3184: Fixed Decision Making Logic
when selecting which secondary storage to use from a selection
URL: https://github.com/apache/cloudstack/pull/3184#discussion_r262885397
##########
File path:
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java
##########
@@ -146,7 +146,13 @@ public ImageStoreEntity getImageStore(String uuid) {
@Override
public DataStore getImageStore(List<DataStore> imageStores) {
if (imageStores.size() > 1) {
- Collections.shuffle(imageStores); // Randomize image store list.
+ Collections.sort(imageStores, new Comparator<DataStore>() {
+ @Override
Review comment:
The idea behind Sorting by capacity was that the imagestore with the most
available capacity will always be on the top of the list hence selected first.
I thought about checking if imagestore has enough capacity but that would
mean that I compare the image size vs remaining capacity of the image store,
that of course would mean that I introduce another parameter to this
`getImageStore` method, perhaps Image id or something, to check for size of
image. Not sure how this will go down with the consumers of `getImageStore`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
