GabrielBrascher opened a new pull request #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171 ## Description <!--- Describe your changes in detail --> When live migrating a KVM VM among local storages, the VM loses the `<iotune>` section on its XML, therefore, having no IO limitations. ``` <iotune> <read_iops_sec>5000</read_iops_sec> <write_iops_sec>5000</write_iops_sec> </iotune> ``` This commit removes the piece of code that deletes the <iotune> section in the XML. @rhtyd @mike-tutkowski @wido @DaanHoogland @nvazquez @kiwiflyer @rafaelweingartner do any of you guys know a reason for keeping the conditional that I removed? It looks like it can be removed without breaking anything. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> **Bug:** - Start a VM running on KVM, with local storage and service offering limiting the VM's IOPS; - verify that the VM's XML file contains `<iotune> ... </iotune>`; - live migrate to another host (with local storage); - verify that the `<iotune> ... </iotune>` section **has been removed** in the VM's XML; **With the fix:** - Start a VM running on KVM, with local storage and service offering limiting the VM's IOPS; - verify that the VM's XML file contains `<iotune> ... </iotune>`; - live migrate to another host (with local storage); - verify that the `<iotune> ... </iotune>` section **stayed** in the VM's XML <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
