GabrielBrascher commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r252503339
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -2046,6 +2207,51 @@ private void
verifyLiveMigrationMapForKVM(Map<VolumeInfo, DataStore> volumeDataS
if (destStoragePoolVO == null) {
throw new CloudRuntimeException("Destination storage pool with
ID " + dataStore.getId() + " was not located.");
}
+
+ if (storageTypeConsistency == null) {
+ storageTypeConsistency = destStoragePoolVO.isManaged();
+ } else if (storageTypeConsistency !=
destStoragePoolVO.isManaged()) {
+ throw new CloudRuntimeException("Destination storage pools
must be either all managed or all not managed");
+ }
+
+ if (!destStoragePoolVO.isManaged()) {
+ if (srcStoragePoolVO.getPoolType() !=
Storage.StoragePoolType.NetworkFilesystem ||
+ destStoragePoolVO.getPoolType() !=
Storage.StoragePoolType.NetworkFilesystem) {
Review comment:
This verification blocks the migration between local storage (storage type
filesystem), allowed with PR #2997.
It should allow migrating also to Storage.StoragePoolType.Filesystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
