rhtyd commented on a change in pull request #2983: KVM live storage migration
intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r252167338
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+ /**
+ * True if volumes source storage are NFS
+ */
+ protected boolean isSourceNfsPrimaryStorage(Map<VolumeInfo, DataStore>
volumeMap) {
+ if (MapUtils.isNotEmpty(volumeMap)) {
+ for (VolumeInfo volumeInfo : volumeMap.keySet()) {
+ StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
+ return storagePoolVO != null &&
+ storagePoolVO.getPoolType() ==
Storage.StoragePoolType.NetworkFilesystem;
+ }
+ }
+ return false;
+ }
+
+ /**
+ * True if destination storage is cluster-wide NFS
+ */
+ protected boolean
isDestinationNfsPrimaryStorageClusterWide(Map<VolumeInfo, DataStore> volumeMap)
{
+ if (MapUtils.isNotEmpty(volumeMap)) {
+ for (DataStore dataStore : volumeMap.values()) {
+ StoragePoolVO storagePoolVO =
_storagePoolDao.findById(dataStore.getId());
+ return storagePoolVO != null &&
+ storagePoolVO.getPoolType() ==
Storage.StoragePoolType.NetworkFilesystem &&
+ storagePoolVO.getScope() == ScopeType.CLUSTER;
+ }
+ }
+ return false;
+ }
+
+ /**
+ * Allow KVM live storage migration for non managed storage when:
+ * - Source host and destination host are different, and are on the same
cluster
+ * - Source and destination storage are NFS
+ * - Destination storage is cluster-wide
+ */
+ protected StrategyPriority
canHandleKVMNonManagedLiveStorageMigration(Map<VolumeInfo, DataStore> volumeMap,
Review comment:
I think the `KvmNonManagedStorageDataMotionStrategy` and
`StorageSystemDataMotionStrategy` are both instantiated and consumed the same
way, we'll have to check if by simply moving the changes will not break the
API. I'll discuss with @nvazquez and get back on this, we can submit a
refactoring PR in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
