GabrielBrascher commented on a change in pull request #3154: Copy template to
target KVM host if needed when migrating local <> local storage
URL: https://github.com/apache/cloudstack/pull/3154#discussion_r251837373
##########
File path:
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java
##########
@@ -101,6 +101,9 @@
ConfigKey.Scope.Cluster,
null);
+ ConfigKey<Integer> PRIMARY_STORAGE_DOWNLOAD_WAIT = new
ConfigKey<Integer>("Storage", Integer.class, "primary.storage.download.wait",
"10800",
Review comment:
`Config.PrimaryStorageDownloadWait` has this configuration indeed.
I can pick from there then and removed this one. However, on the other hand,
`Config.PrimaryStorageDownloadWait` is deprecated. Should I use
`Config.PrimaryStorageDownloadWait`, or remove the
`Config.PrimaryStorageDownloadWait` and keep with the `new
ConfigKey<Integer>...`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
