1m2c3t4 opened a new pull request #3143: Fix some LGTM alerts URL: https://github.com/apache/cloudstack/pull/3143 ## Description LGTM has raised a number of alerts from analysis of apache/cloudstack (https://lgtm.com/projects/g/apache/cloudstack/alerts/?mode=tree). This pull request is to fix some of the problems raised. Specifically, - 2 `Array index out of bounds` errors in NetworkOrchestrator - 1 `Equals method does not inspect argument type` in DeployDestination - 1 `Equals on incomparable types` in ApiResponseHelper - 28 `Contradictory type checks` in ApiServer, HypervDirectConnectResource and Ovm3HypervisorResource ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
