rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225524176
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java
##########
@@ -52,7 +57,15 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
+ updateManagementServerHostUuid(conn);
+ }
+ private void updateManagementServerHostUuid(Connection conn) {
+ try (final PreparedStatement updateStatement =
conn.prepareStatement("UPDATE cloud.mshost SET uuid=UUID()")) {
Review comment:
shouldn't you use a `where` clause here? I mean, you only want to update the
hosts that have the `uuid == null`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
