rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225397031
##########
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
- setRestartRequired(network, true);
+ setRestartRequired(network, false);
Review comment:
@rafaelweingartner the `restart required` flag is a presentational issue and
used to communicate to users/admins that a network requires a restart because
likely a previous restart attempt failed..
If you restart a network current without the cleanup=true flag, in the API
response and UI the network's restart required state will change to true which
is wrong. The state/flag should only be true if something went wrong in its
last restart. You may read a recent thread here:
https://markmail.org/message/bn57hymlvohf54b7
This change is in line with the logic used by the restart VPC code, i.e.
don't set the restart required flag to true if there was no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
