jayakarteek commented on a change in pull request #2058: CLOUDSTACK-9888: 
Duplicate usage while processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139943969
 
 

 ##########
 File path: usage/src/com/cloud/usage/UsageManagerImpl.java
 ##########
 @@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
 
         if (EventTypes.EVENT_VM_START.equals(event.getType())) {
             // create a new usage_VM_instance row for this VM
-            try {
 
 Review comment:
   I already tested the scenario with out the fix and posted the results in 
above comments 
   Also @niteshsarda  tested the fix and gave test LGTM.
   Are you looking for marvin test case
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to