wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132430071
########## File path: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh ########## @@ -39,12 +39,76 @@ function install_cloud_scripts() { /etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \ /etc/profile.d/cloud.sh - chkconfig --add cloud-early-config - chkconfig cloud-early-config on - chkconfig --add cloud-passwd-srvr - chkconfig cloud-passwd-srvr off - chkconfig --add cloud - chkconfig cloud off + cat > /lib/systemd/system/cloud-early-config.service << EOF Review comment: Shouldn't we put these in */etc/systemd/system* as they are kind of custom? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services