rhtyd commented on a change in pull request #2175: 4.10 to 4.11 upgrade path
URL: https://github.com/apache/cloudstack/pull/2175#discussion_r126882899
##########
File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -104,210 +105,353 @@
public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
private static final Logger s_logger =
Logger.getLogger(DatabaseUpgradeChecker.class);
-
- protected Map<CloudStackVersion, DbUpgrade[]> _upgradeMap = new
HashMap<>();
-
- @Inject
- VersionDao _dao;
-
private final ImmutableList<CloudStackVersion> availableVersions;
+ protected Map<CloudStackVersion, DbUpgrade[]> _upgradeMap = new
HashMap<>();
+ @Inject VersionDao _dao;
public DatabaseUpgradeChecker() {
Review comment:
@DaanHoogland it will be hard to review the changes as there as all the
newlines and formating has changed. Kindly revert some of that, for example
having the `@Annotations` above the variable declarations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
