piyush5netapp commented on PR #14192: URL: https://github.com/apache/cloudstack/pull/14192#issuecomment-6858703341
> Overall it looks good. A single remark before approving: could you check whether live ONTAP LUNs are undesirably classified as stale and detached when the agent property `iscsi.session.cleanup.enabled` is true? We may need to adapt `IscsiStorageCleanupMonitor.java` to consider the ONTAP LUNs as well. @winterhazel That a great catch and I have already drafted a mail for the same which I will send it in now to dev community. Current implementation IscsiStorageCleanupMonitor will actually mark the active Ontap luns to be marked for cleanup as it matched with "by-path" regex. We need to write code if user can configured scsi.session.cleanup.enabled as true. Could you please reply to the mail about your thought ? I feel current logic in IscsiStorageCleanupMonitor matching "by-path" with libvirt source dev should be changed and OUI of vendor should checked . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
