DaanHoogland commented on PR #14581:
URL: https://github.com/apache/cloudstack/pull/14581#issuecomment-6769835235
Thanks @vanecka,
Observation 1: same cause as the rest of this PR: the Instance Snapshots tab
(and the Backups tab) on the instance page didn't send the instance's project.
Both now do, so a project-owned instance's snapshots and backups show up
outside the project view as well. Note that a snapshot taken while the instance
was still yours stays owned by you, so it shows under Compute → Instance
Snapshots in the Default view rather than on the (now project-owned) instance's
tab.
Observation 2: that's deliberate server-side behaviour: assigning an
instance to another owner is refused while its volumes have snapshots ("Detach
volume or remove snapshots for the volume before assigning VM to another
user"). Whether snapshots should move along with the instance is a fair
question, but it's a backend change outside the scope of this UI fix. Could you
open a separate issue for it?
On this, I would refuse it, because a snapshot is a first class citizen in
cloudstack with a lifecycle and owner not tightly coupled to the
volume/instance it is a snapshot from.
On the side note: nice and bummer ;). Glad the snapshot dialog works now.
The "internal error creating Snapshot" issue is worth its own issue I think. I
would like not to creep the scope of this PR for it. Can you reproduce it and
add some logging information to the issue, if you create it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]