JoaoJandre commented on code in PR #14473:
URL: https://github.com/apache/cloudstack/pull/14473#discussion_r4467773785
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1872,8 +1872,7 @@ private void checkPodAttributesForNonEdgeZone(final long
podId, final String pod
}
}
- final String checkPodCIDRs = _configDao.getValue("check.pod.cidrs");
- if (checkPodCIDRs == null || checkPodCIDRs.trim().isEmpty() ||
Boolean.parseBoolean(checkPodCIDRs)) {
+ if (ManagementServer.CheckPodCIDRs.value()) {
checkPodCidrSubnets(zone.getId(), podId, cidr);
Review Comment:
If `check.pod.cidrs` is empty or null, the parseBoolean will return false.
Previously the condition would be true, and now it will be false.
The relevant question is, can `check.pod.cidrs` be empty or null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
