weizhouapache commented on code in PR #11931:
URL: https://github.com/apache/cloudstack/pull/11931#discussion_r4398454112
##########
test/integration/smoke/test_vm_life_cycle.py:
##########
@@ -1707,12 +1708,17 @@ def get_target_host(self, virtualmachineid):
return target_hosts[0]
- def get_target_pool(self, volid):
- target_pools = StoragePool.listForMigration(self.apiclient, id=volid)
+ def get_target_pool(self, vol):
+ target_pools = StoragePool.listForMigration(self.apiclient, id=vol.id)
if target_pools is None or len(target_pools) == 0:
self.skipTest("Not enough storage pools found for migration")
+ volume = Volume.list(self.apiclient, id=vol.id)[0]
+ source_pool = list_storage_pools(self.apiclient,
id=volume.storageid)[0]
+ if source_pool.type == 'RBD' and target_pools[0].type == 'RBD':
+ self.skipTest("Live VM migration between RBD pools is unsupported")
Review Comment:
let's make simple, do not consider live vm migration with RBD volumes
it will be addressed in future releases
```
- if source_pool.type == 'RBD' and target_pools[0].type == 'RBD':
- self.skipTest("Live VM migration between RBD pools is
unsupported")
+ if source_pool.type == 'RBD':
+ self.skipTest("Live VM migration from RBD pool is unsupported")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
