weizhouapache commented on PR #13281: URL: https://github.com/apache/cloudstack/pull/13281#issuecomment-6494819638
> LGTM, Tested manually with Oracle 8 and Ubuntu24 > > Performed vm lifecyle opeerations and there was no issue with it > > Before fix > > ``` > > [root@ref-trl-12535-k-Mol8-kiran-chavala-kvm2 ~]# virsh dumpxml i-2-12-VM | grep seclabel > <seclabel type='dynamic' model='dac' relabel='yes'> > </seclabel> > > > [root@ref-trl-12535-k-Mol8-kiran-chavala-kvm2 ~]# cat /etc/libvirt/qemu.conf |grep security > > > > [root@ref-trl-12535-k-Mol8-kiran-chavala-kvm2 ~]# find / -name "setup_agent.sh" > /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/setup_agent.sh > > > [root@ref-trl-12535-k-Mol8-kiran-chavala-kvm2 ~]# virsh dumpxml i-2-12-VM | grep seclabel > <seclabel type='dynamic' model='dac' relabel='yes'> > </seclabel> > ``` > > After fix > > There is no setup_agent sh , kvm host gets added successully > > [root@ref-trl-12537-k-Mol8-kiran-chavala-kvm1 ~]# find / -name "setup_agent.sh" > > If selinux is enabled then the admin should make sure > > ``` > > cat /etc/libvirt/qemu.conf > security_driver = "selinux" > [root@ref-trl-12548-k-Mol8-kiran-chavala-kvm2 ~]# getenforce > Enforcing > > > > > [root@ref-trl-12537-k-Mol8-kiran-chavala-kvm1 ~]# virsh dumpxml i-2-3-VM | grep seclabel > <seclabel type='dynamic' model='selinux' relabel='yes'> > </seclabel> > <seclabel type='dynamic' model='dac' relabel='yes'> > </seclabel> > ``` thanks @kiranchavala for testing with different OS distributions, host settings and operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
