JoaoJandre commented on code in PR #14413:
URL: https://github.com/apache/cloudstack/pull/14413#discussion_r4413926450
##########
ui/src/views/compute/wizard/ComputeSelection.vue:
##########
@@ -226,10 +274,28 @@ export default {
}
if (this.preFillContent.memory) {
this.memoryInputValue = this.preFillContent.memory
+ this.memoryDisplayValue = parseFloat((this.memoryInputValue /
1024).toFixed(2))
}
this.updateComputeCpuNumber(this.preFillContent.cpunumber ||
this.cpuNumberInputValue)
this.updateComputeCpuSpeed(this.preFillContent.cpuspeed ||
this.cpuSpeedInputValue)
- this.updateComputeMemory(this.preFillContent.memory ||
this.memoryInputValue)
+ this.updateComputeMemory(this.memoryDisplayValue)
Review Comment:
@saurabhkushwaha438 This looks better. But IMHO I think that having a slider
for GiB that goes in increments of 0.01 is not a very interesting design. I
think both the GiB and MiB increments should be of 1 (of their respective unit
of mesurement).
If you want to have a VM with 1.6 GiB for some reason, you can just use the
MiB slider. I believe most users will use whole GiB numbers, not fractions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
