RosiKyu commented on PR #14407:
URL: https://github.com/apache/cloudstack/pull/14407#issuecomment-6464958886
Tested on build 24.0.0-shapeblue22317 (head 3336b483e8e), upgraded from
4.23.0.0: first the management server, then the agents. The q35 hosts
(host.cdrom.max.count 2) use config drive and NAS backup.
LGTM for the reported issues (#13484 and #14321): data volumes no longer
take the device ids of the CD-ROMs or the config drive ISO, on running and
stopped VMs, with 1 and 2 ISOs. No regression was found.
### Tested/Verified
- Bugs reproduced on 4.23.0.0:
- the 3rd data volume collides on sde with the config drive ISO, or with
the empty 2nd CD-ROM;
- on stopped VMs it gets deviceid 4 and the VM can't start;
- with vm.iso.max.count=2, no new VM on a config drive network could start.
- PR build, q35 scsi and virtio VMs: data volumes get 1, 2, 6, 7 with config
drive and 1, 2, 5, 6 without. The VMs start.
- Explicit device ids: reserved ids are rejected with the new message ([3,
4, 5] with config drive, [3, 4] without). Out of range ids are rejected, and
free ids are accepted.
- 32-volume limit: still reachable (1, 2, 6 to 35).
- vm.iso.max.count=2, i440fx and q35: ISO 1, the config drive and ISO 2 are
on 3, 4 and 5 (ISO 2 on sata sdf). Detaching ISO 2 leaves the config drive, and
stop/start keeps all 3 CD-ROMs.
- Lifecycle: reboot and live migration keep the device ids and targets.
- Notes confirmed:
- VMs with a volume already on a reserved id can't start until the volume
is detached and attached;
- ISO 2 on a running config drive VM needs a restart if the VM was started
with vm.iso.max.count=1.
- Upgrade:
- a new management server with 4.23 agents already gives 1, 2, 6;
- existing i440fx VMs with volumes on 4 and 5 keep working;
- an ISO in the 2nd slot moves to sdf once the VM gets a config drive NIC.
- Behaviour change: an explicit deviceid=5 on config drive VMs was accepted
on 4.23.0.0 and is now rejected.
- Other paths:
- deploy with a data disk offering;
- create a VM from a backup of a config drive VM;
- restore in place;
- unmanaged import with 4 data disks (1, 2, 6, 7).
### Potential issues (both only with vm.iso.max.count=2)
1. A VM without config drive that later gets a config drive NIC keeps its
data volume on deviceid 5. The PR build itself assigned that id. At setting 1
the VM starts. At 2 it can't start, because the volume and the ISO 2 CD-ROM
both get sdf.
2. A VM created from a backup keeps the backup's deviceid 5 on a config
drive network. At setting 1 the VM starts; at 2 it can't start (target 'sdf'
duplicated). The same backup on a network without config drive gives a running
VM. This is the same path as the open backup case on #14073. It was not checked
on 4.23.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
