DaanHoogland commented on code in PR #14223:
URL: https://github.com/apache/cloudstack/pull/14223#discussion_r4398519493
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java:
##########
@@ -361,7 +361,7 @@ private void
validateKubernetesClusterScaleSizeParameters(KubernetesClusterNodeT
}
}
- private void scaleKubernetesClusterOffering(KubernetesClusterNodeType
nodeType, ServiceOffering serviceOffering,
+ protected void scaleKubernetesClusterOffering(KubernetesClusterNodeType
nodeType, ServiceOffering serviceOffering,
Review Comment:
@andrija, looks like this one has gone with your changes on Pearl's remarks.
But have a look at these:
https://github.com/apache/cloudstack/pull/14223/changes?panel=alerts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
